Refactor/remove custom service type no custom type hash#1264
Merged
krhubert merged 3 commits intorefactor/remove-custom-service-typefrom Aug 28, 2019
Conversation
NicolasMahe
changed the base branch from
dev
to
refactor/remove-custom-service-type
NicolasMahe
force-pushed
the
refactor/remove-custom-service-type-no-custom-type-hash
branch
from
342bcf9 to
281dd92
Compare
krhubert
deleted the
refactor/remove-custom-service-type-no-custom-type-hash
branch
NicolasMahe
added
release:change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependant on #1263
Will merge to #1260
Remove the custom type define for the service.hash so the hash is still send as plain string on the API.