Skip to content

Add --exp to dev command#1331

Merged
NicolasMahe merged 1 commit intodevfrom
feature/optional-experimental-flag
Sep 12, 2019
Merged

Add --exp to dev command#1331
NicolasMahe merged 1 commit intodevfrom
feature/optional-experimental-flag

Conversation

@NicolasMahe
Copy link
Copy Markdown
Member

@NicolasMahe NicolasMahe commented Sep 12, 2019

It's REALLY annoying to deactivate the network by removing the flag in the dev script.
So now we can pass the flag --experimental-network to enable the network feature.
This is only a temp solution until the network is the default solution and fully implemented!

This PR is a simplified version of #1262.

./dev # no network
./dev --exp # with network
./dev --exp --validator # with network and node is validator

@NicolasMahe NicolasMahe added enhancement New feature or request release:add Pull requests that add something labels Sep 12, 2019
@NicolasMahe NicolasMahe added this to the next milestone Sep 12, 2019
@NicolasMahe NicolasMahe self-assigned this Sep 12, 2019
@krhubert
Copy link
Copy Markdown
Contributor

I like it because it was annoying to me as well.

If it's temporary, can we make a short flag for this? It will be really painful to write --experimental-network if one start working on the network. -n for network? what do you think?

Comment thread dev Outdated
@antho1404
Copy link
Copy Markdown
Member

I'm fine to make it shorter and fine to keep it like it anyway I use the reverse-i-search all the time so it's will not change anything

@NicolasMahe NicolasMahe force-pushed the feature/optional-experimental-flag branch from 7bbc9a8 to 6222886 Compare September 12, 2019 05:39
@NicolasMahe NicolasMahe changed the title Add --experimental-network to dev command Add --exp to dev command Sep 12, 2019
@NicolasMahe NicolasMahe merged commit 27de433 into dev Sep 12, 2019
@NicolasMahe NicolasMahe deleted the feature/optional-experimental-flag branch September 12, 2019 05:43
@NicolasMahe NicolasMahe added experimental and removed enhancement New feature or request release:add Pull requests that add something labels Sep 23, 2019
@NicolasMahe NicolasMahe mentioned this pull request Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants