Namespace protobuf types and api#1337
Merged
NicolasMahe merged 2 commits intodevfrom Sep 18, 2019
Merged
Conversation
antho1404
force-pushed
the
feature/namespace-proto
branch
from
a363342 to
176dc8f
Compare
antho1404
force-pushed
the
feature/namespace-proto
branch
from
176dc8f to
05c1396
Compare
krhubert
approved these changes
Sep 16, 2019
NicolasMahe
approved these changes
Sep 18, 2019
NicolasMahe
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal to fix #1236
All the types/api should be prefixed all the time to avoid conflicts. I created an issue on Tendermint for them to fix that too but this is the fix on our end that is needed anyway if developers use the sdk directly.
This is a big breaking change on the API and we need to make sure there is no side effect with that.