Add credential using grpc metadata#1355
Merged
NicolasMahe merged 3 commits intodevfrom Sep 25, 2019
Merged
Conversation
This was referenced Sep 24, 2019
krhubert
approved these changes
Sep 24, 2019
antho1404
approved these changes
Sep 25, 2019
Member
antho1404
left a comment
antho1404
left a comment
There was a problem hiding this comment.
Just one small issue but that will be solved at the end of this sprint, this API crashes when we don't have the --exp flag, probably because the account sdk is not created in the deprecated mode.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add credential system using grpc metadata for:
service.createservice.deleteaccount.deletecloses #1350