Skip to content

Fix copy of folder in dev script#1360

Merged
NicolasMahe merged 2 commits intodevfrom
fix/dev-script
Sep 25, 2019
Merged

Fix copy of folder in dev script#1360
NicolasMahe merged 2 commits intodevfrom
fix/dev-script

Conversation

@krhubert
Copy link
Copy Markdown
Contributor

As showed here cp works differently on linux and mac. This fix replaces cp with rsync to make behave the same.

to test run:

./dev --exp --validator 

and make sure node is a validator

@krhubert krhubert added the bug Something isn't working label Sep 25, 2019
@krhubert krhubert added this to the next milestone Sep 25, 2019
@krhubert krhubert self-assigned this Sep 25, 2019
@NicolasMahe NicolasMahe merged commit c698a96 into dev Sep 25, 2019
@NicolasMahe NicolasMahe deleted the fix/dev-script branch September 25, 2019 10:56
@NicolasMahe NicolasMahe changed the title Use rsync to copy a file Fix copy of folder in dev script Oct 25, 2019
@NicolasMahe NicolasMahe added the release:fix Pull requests that fix something label Oct 25, 2019
@NicolasMahe NicolasMahe mentioned this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working release:fix Pull requests that fix something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants