Skip to content

Container package refactor#1400

Merged
antho1404 merged 6 commits intodevfrom
refactor/container-pkg
Oct 21, 2019
Merged

Container package refactor#1400
antho1404 merged 6 commits intodevfrom
refactor/container-pkg

Conversation

@krhubert
Copy link
Copy Markdown
Contributor

@krhubert krhubert commented Oct 7, 2019 •
edited
Loading

close #1395

Refactor package and tests:

  • cache shared network id
  • add clean up method (will also stop the services)
  • remove dockertest and mocks packages
  • refactor for Build and Shared network
  • update docker client
  • remove usage on context timeout due to new client option
  • update golangci-lint skip files and dirs
  • update circleci config

@krhubert krhubert force-pushed the refactor/container-pkg branch 4 times, most recently from 7a4e690 to 1634394 Compare October 9, 2019 13:55
@krhubert krhubert requested review from NicolasMahe and antho1404 and removed request for NicolasMahe October 9, 2019 13:55
@krhubert krhubert marked this pull request as ready for review October 9, 2019 14:01
@krhubert krhubert self-assigned this Oct 9, 2019
@krhubert krhubert added this to the next milestone Oct 9, 2019
@krhubert krhubert requested a review from NicolasMahe October 9, 2019 14:02
@krhubert krhubert force-pushed the refactor/container-pkg branch from 1634394 to 5a5e4f1 Compare October 9, 2019 14:30
antho1404
antho1404 approved these changes Oct 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@antho1404 antho1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, I did few tests with dependencies and so on and I didn't find any issue. Good cleanup :)

Comment thread core/main.go
NicolasMahe
NicolasMahe reviewed Oct 13, 2019
View reviewed changes
Comment thread container/container.go Outdated
Comment thread container/container.go
Comment thread container/container.go
NicolasMahe
NicolasMahe reviewed Oct 13, 2019
View reviewed changes
Comment thread container/service_options_test.go
@krhubert krhubert force-pushed the refactor/container-pkg branch from 5a5e4f1 to 2c81132 Compare October 14, 2019 20:09
@krhubert krhubert requested a review from NicolasMahe October 14, 2019 20:10
@antho1404
Copy link
Copy Markdown
Member

antho1404 commented Oct 16, 2019

I didn't see the modification because of the force push, good that the linter broke.
@krhubert could you fix the issue please :)

@krhubert krhubert force-pushed the refactor/container-pkg branch from 2c81132 to 8744f38 Compare October 16, 2019 07:53
@NicolasMahe NicolasMahe requested a review from antho1404 October 21, 2019 04:34
NicolasMahe
NicolasMahe reviewed Oct 21, 2019
View reviewed changes
Comment thread container/container.go Outdated
@NicolasMahe
Copy link
Copy Markdown
Member

NicolasMahe commented Oct 21, 2019

@antho1404 please do a last review and merge if everything is ok

@antho1404 antho1404 merged commit 0f0f267 into dev Oct 21, 2019
@antho1404 antho1404 deleted the refactor/container-pkg branch October 21, 2019 09:29
@NicolasMahe NicolasMahe added the release:change Pull requests that change something existant label Oct 25, 2019
This was referenced Oct 25, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antho1404 antho1404 antho1404 approved these changes

@NicolasMahe NicolasMahe NicolasMahe approved these changes

Assignees

@krhubert krhubert

Labels

refactoring release:change Pull requests that change something existant

Projects

None yet

Milestone

v0.16.0

Development

Successfully merging this pull request may close these issues.

Improve container package test

3 participants

@krhubert @antho1404 @NicolasMahe