Conversation
targets: dev-start dev-stop e2e clean-e2e clean-docker clean-build
NicolasMahe
reviewed
Oct 26, 2019
NicolasMahe
reviewed
Oct 26, 2019
NicolasMahe
reviewed
Oct 26, 2019
Member
|
I fixed the CI on PR #1436 |
Add CI e2e task and update ci caching
antho1404
approved these changes
Oct 28, 2019
NicolasMahe
approved these changes
Oct 28, 2019
Member
NicolasMahe
left a comment
NicolasMahe
left a comment
There was a problem hiding this comment.
@krhubert can you clean the git history (there is a WIP commit) before merge
NicolasMahe
changed the title
NicolasMahe
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds possibilities to run e2e with
makeand run them in circleciclose #1418
close #1417
close #1419