Skip to content

Add config log format validation#1449

Merged
NicolasMahe merged 2 commits intodevfrom
feature/format-validation
Oct 31, 2019
Merged

Add config log format validation#1449
NicolasMahe merged 2 commits intodevfrom
feature/format-validation

Conversation

@krhubert
Copy link
Copy Markdown
Contributor

@krhubert krhubert commented Oct 30, 2019

close #1387

@krhubert krhubert added bug Something isn't working enhancement New feature or request labels Oct 30, 2019
@krhubert krhubert added this to the next milestone Oct 30, 2019
@krhubert krhubert requested a review from NicolasMahe October 30, 2019 22:26
@krhubert krhubert self-assigned this Oct 30, 2019
Comment thread config/config.go
Copy link
Copy Markdown
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krhubert Don't forget to remove the now useless test lines L163-R165:

engine/config/config.go

Lines 163 to 165 in 43514a9

if !xstrings.SliceContains([]string{"text", "json"}, c.Log.Format) {
return fmt.Errorf("config.Log.Format value %q is not an allowed", c.Log.Format)
}

@NicolasMahe NicolasMahe merged commit f9ebe82 into dev Oct 31, 2019
@NicolasMahe NicolasMahe deleted the feature/format-validation branch October 31, 2019 08:13
@NicolasMahe NicolasMahe removed the bug Something isn't working label Oct 31, 2019
@NicolasMahe NicolasMahe changed the title Add config.log.format validation Add config log format validation Nov 26, 2019
@NicolasMahe NicolasMahe added the release:add Pull requests that add something label Nov 26, 2019
@NicolasMahe NicolasMahe mentioned this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release:add Pull requests that add something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve config validation

3 participants