Single cosmos account#1459
Conversation
| return errs.ErrorOrNil() | ||
| } | ||
|
|
||
| func loadOrGenConfigAccount(kb *cosmos.Keybase, cfg *config.Config) (keys.Info, error) { |
There was a problem hiding this comment.
this could be in engine keybase package to extend cosmos keybase.
There was a problem hiding this comment.
All the function you mean?
I already put the Exist function in keybase.
I don't think we will have this logic of loadOrGen in any other place.
There was a problem hiding this comment.
All the function you mean?
Yes
I don't think we will have this logic of loadOrGen in any other place.
And that's fine. The Keybase wrapper was created to handle such cases. so you don't put them in other places (like main.go).
func (kb *Keybase) LoadOrGenAccount(name, password string) (keys.Info, error) {
}There was a problem hiding this comment.
This is not compatible with Anthony's suggestion https://github.com/mesg-foundation/engine/pull/1459/files#r342436168
antho1404
left a comment
antho1404
left a comment
There was a problem hiding this comment.
One last improvement, but it can be done on another PR https://github.com/mesg-foundation/engine/pull/1459/files/4373f386792b8590704f46939585f82b1240a350#r342436168
3 participants
Simplify the account management to use only one account across the Engine that can be configured in Config. Rename the generated account to
enginecloses #1458