Use filter in list instance api#1473
Merged
NicolasMahe merged 1 commit intodevfrom Nov 6, 2019
Merged
Conversation
krhubert
force-pushed
the
fix/instance-list-filter
branch
from
44107b4 to
a09e07d
Compare
antho1404
approved these changes
Nov 6, 2019
NicolasMahe
approved these changes
Nov 6, 2019
NicolasMahe
reviewed
Nov 6, 2019
| // List instances. | ||
| func (s *InstanceServer) List(ctx context.Context, request *protobuf_api.ListInstanceRequest) (*protobuf_api.ListInstanceResponse, error) { | ||
| instances, err := s.sdk.Instance.List(&instancesdk.Filter{ServiceHash: request.ServiceHash}) | ||
| instances, err := s.sdk.Instance.List(&instancesdk.Filter{ServiceHash: request.Filter.ServiceHash}) |
Member
There was a problem hiding this comment.
request.Filter should be nilable.
Should add a check if request.Filter is nil
This was referenced Nov 12, 2019
NicolasMahe
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1466