Filter instances on backend side

[krhubert]

clsoes #1467

[krhubert]

I don't know why e2e fails, can you help me fix that?

[NicolasMahe]

I don't know why e2e fails, can you help me fix that?

servicesdk.hash is using proto.Marshal.

// Hash returns the calculate hash of a service.
func (s *SDK) Hash(req *api.CreateServiceRequest) (hash.Hash, error) {
	var h hash.Hash
	b, err := proto.Marshal(req)
	if err != nil {
		return nil, err
	}
	if err := s.client.Query("custom/"+backendName+"/hash", cmn.HexBytes(b), &h); err != nil {
		return nil, err
	}
	return h, nil
}

---

EDIT: i fixed it

[antho1404]

Few issues while testing:

Crash

grpcurl -proto protobuf/api/instance.proto -plaintext localhost:50052 mesg.api.Instance/List

This crashes

panic: MarshalBinaryBare cannot marshal a nil pointer directly. Try wrapping in a struct?

Weird behavior with the filter

That might be related to grpcurl or base64 conversion but if I use the filter with slightly different values it still matches when it shouldn't

grpcurl -proto protobuf/api/instance.proto -plaintext -d "{\"filter\": {}}" localhost:50052 mesg.api.Instance/List
➜  engine git:(feature/filter-instance) grpcurl -proto protobuf/api/instance.proto -plaintext -d "{\"filter\": {}}" localhost:50052 mesg.api.Instance/List
{
  "instances": [
    {
      "hash": "r1gIofZs2MZQVBsm6TGp5MGEoafY148TGNRJEnkvn1o=",
      "serviceHash": "g6BhSw8QiSibfNkIIdkc5QRnhJVo4GJfE8QPcjKVP3I=",
      "envHash": "T1PNoYwrqgwDVLtfmj7L5e0Sq02OEbqHPC8RFhICuUU="
    }
  ]
}

# valid 
grpcurl -proto protobuf/api/instance.proto -plaintext -d "{\"filter\": {\"serviceHash\": \"g6BhSw8QiSibfNkIIdkc5QRnhJVo4GJfE8QPcjKVP3I=\"}}" localhost:50052 mesg.api.Instance/List

# still valid by changing the last letter `I` per `J`.
grpcurl -proto protobuf/api/instance.proto -plaintext -d "{\"filter\": {\"serviceHash\": \"g6BhSw8QiSibfNkIIdkc5QRnhJVo4GJfE8QPcjKVP3J=\"}}" localhost:50052 mesg.api.Instance/List

[krhubert]

@antho1404

Fixed issues with panic. Also add e2e tests for different instance hash and it works as expected. I'm not going to debug grpcurl as it is just a helper tool. From e2e tests and code perespective everything work fine.