Add amino encoding functionality to proto Struct#1502
Merged
Conversation
NicolasMahe
force-pushed
the
feature/struct-amino
branch
from
f1ca383 to
0cb5c8a
Compare
krhubert
reviewed
Nov 15, 2019
krhubert
approved these changes
Nov 15, 2019
antho1404
approved these changes
Nov 15, 2019
This was referenced Nov 15, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amino:"unsafe"flag to protoNumbertype to make it work with amino.MarshalAminoandUnmarshalAminofunctions to protoStructtype to transform the Fields type frommap[string]*Valueto a key/value value and vice-versa. The key/value array is sorted by keys to guarantee its order and generate the same hash (see order of values in the tests).Suggested solution from tendermint/go-amino#154 (comment)
Closes #1492
Related to #1493