Skip to content

Remove service env MESG_TOKEN#1513

Merged
NicolasMahe merged 1 commit intodevfrom
feature/remove-mesg-token
Nov 19, 2019
Merged

Remove service env MESG_TOKEN#1513
NicolasMahe merged 1 commit intodevfrom
feature/remove-mesg-token

Conversation

@NicolasMahe
Copy link
Copy Markdown
Member

Remove service env MESG_TOKEN until a real auth system is put in place

@NicolasMahe NicolasMahe added this to the next milestone Nov 19, 2019
@NicolasMahe NicolasMahe self-assigned this Nov 19, 2019
@NicolasMahe NicolasMahe merged commit 0b000a8 into dev Nov 19, 2019
@NicolasMahe NicolasMahe deleted the feature/remove-mesg-token branch November 19, 2019 05:20
@antho1404
Copy link
Copy Markdown
Member

Why this has been merged without approval?
We shouldn't remove this injected env variable. Without this, the service doesn't know what to communicate back to the engine.
This needs to be reverted also I'm pretty sure that tests will fail on this one but you didn't wait for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants