Add support for dockerignore#392
Merged
NicolasMahe merged 6 commits intodevfrom Aug 27, 2018
Merged
Conversation
ilgooz
approved these changes
Aug 26, 2018
krhubert
reviewed
Aug 26, 2018
| if _, err := os.Stat(filepath.Join(path, ".mesgignore")); err == nil { | ||
| // TODO: remove for a future release | ||
| d.sendStatus(fmt.Sprintf("%s [DEPRECATION] please use .dockerignore instead of .mesgignore", aurora.Red("⨯")), DONE) | ||
| } else { |
Contributor
There was a problem hiding this comment.
Remove else? there will be warning about .mesgingore file, but there will be no info about build complete status (which will happen here). So display deprecation msg + build msg.
Todo: s/DEPRECATION/DEPRECATED/
Contributor
There was a problem hiding this comment.
i agree, requesting changes
ilgooz
suggested changes
Aug 26, 2018
Contributor
ilgooz
left a comment
ilgooz
left a comment
There was a problem hiding this comment.
status message bug, also please add tests for this to deploy_test.go
Member
Author
|
modifications done |
ilgooz
approved these changes
Aug 26, 2018
NicolasMahe
approved these changes
Aug 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this is released, we need to update the javascript template to use the dockerignore file instead of mesgignore file
https://github.com/mesg-foundation/template-service-javascript/edit/master/template/.mesgignore