Fix/cli logs#464
Conversation
|
@antho1404 can you review please |
| return err | ||
|
|
||
| // XXX: double check if sleep before was too short. | ||
| case <-time.After(5 * time.Second): |
There was a problem hiding this comment.
we might have some long running tasks, for example submitting a bitcoin transaction will take few minutes if we wait for the confirmation.
If it's too long for users, they can exit.
There was a problem hiding this comment.
I discussed this with @NicolasMahe as well. The only solution for this problem is making sure stream reader is ready to use after the open. Otherwise, we can break after a long running task, or app can miss the results because we have no guarantee that 1 second sleep would be enough. Also, we need this thing working with network PoC. I thought about fixing it right after I get home.
| max := xstrings.FindLongest(dependencies) | ||
| for i, dep := range dependencies { | ||
| c := colors[i%len(colors)] | ||
| prefixes[dep] = c.Sprintf("% *s |", max, dep) |
There was a problem hiding this comment.
This is not valid because the display is different now. The dependency name is aligned to the right instead of the left.
3 participants
No description provided.