Conversation
…o core/api protobuf definition.
krhubert
approved these changes
Sep 17, 2018
krhubert
suggested changes
Sep 17, 2018
Contributor
krhubert
left a comment
krhubert
left a comment
There was a problem hiding this comment.
Change dir name from service to serviceapi and core to coreapi. It's consider a good practice to name go package the same as directory
Member
Author
|
Changes done |
krhubert
approved these changes
Sep 18, 2018
Contributor
|
lgtm :) |
antho1404
approved these changes
Sep 18, 2018
Member
Author
|
This pull request has been mentioned on MESG. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.