Merged
Conversation
ilgooz
reviewed
Oct 21, 2018
ilgooz
force-pushed
the
bug/completed-task-in-memory
branch
3 times, most recently
from
b473dc2 to
8e08077
Compare
ilgooz
force-pushed
the
bug/completed-task-in-memory
branch
from
8e08077 to
5d6fb9b
Compare
Member
Author
|
Thanks for the fixes, I'm also working on having a database to store all these executions so all these queues should disappear soon hopefully. |
NicolasMahe
approved these changes
Oct 22, 2018
Contributor
|
@krhubert could you review and merge please? |
krhubert
approved these changes
Oct 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might me really related to #540
Every time we were executing a task, the executions was kept in memory, making the memory going up more and more over time.
This is a small fix to remove the execution when it's done. We should later on put that in a database but that will be another work