Fix issue when many containers are created but only one is deleted#586
Merged
Fix issue when many containers are created but only one is deleted#586
Conversation
NicolasMahe
previously approved these changes
Nov 28, 2018
Contributor
|
Tests are not passing. |
Member
@ilgooz When the test are failing with the following type of error, you can go on circleci and press rerun workflow. thx |
Contributor
|
But the tests are not passing due to this error: It's timeout on test stop |
Member
|
Where do you see this test failing? |
Contributor
|
@NicolasMahe It's there, near to beginning of logs: https://circleci.com/gh/mesg-foundation/core/4541?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link Tests should be updated to meet with the new behavior that this PR introduces. |
Member
Contributor
@NicolasMahe Of course, by the way, let's merge testify mocks: #588 |
…ervice test to use mockery
NicolasMahe
approved these changes
Nov 29, 2018
krhubert
approved these changes
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a MESG service is created but has some errors like for example like that:
When the MESG service starts with these two docker services, the first service will crash because it cannot access the database that takes time to start and will restart.
When it restarts docker stop the initial container but without destroying it so we needed to delete this container. If the initial service crashes multiple times, multiples containers are stopped but not deleted. This PR is fixing that by ensuring that all the remaining containers are actually deleted and doesn't block the execution of a new service and doesn't stuck the action to stop the MESG service (pending indefinitely because a container is still existing)