Conversation
ilgooz
previously requested changes
Dec 6, 2018
Contributor
ilgooz
left a comment
ilgooz
left a comment
There was a problem hiding this comment.
@mesg-foundation/core Do we want to keep vendor/ folder or not? I'd like to remove it also but we should create an another repo and keep vendors there and update it with a CI task (for master branch). We don't need to pull it from there, it is just for securing the vendors. This way if some of them gets deleted from the internet we'll be able to recover.
krhubert
dismissed
ilgooz’s stale review
This PR is about update go version and not removing vendor directory (as it requires more changes0
NicolasMahe
approved these changes
Dec 9, 2018
antho1404
approved these changes
Dec 10, 2018
Member
|
This pull request has been mentioned on MESG Community. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #468
Are you ready to switch to go 1.11?! 😍😍😍😂
List of changes:
go modinstead of dep