Conversation
NicolasMahe
requested review from
antho1404,
ilgooz and
krhubert
and removed request for
antho1404 and
ilgooz
antho1404
reviewed
Dec 18, 2018
krhubert
reviewed
Dec 18, 2018
| if err := exec.Complete(outputKey, outputData); err != nil { | ||
| return err | ||
|
|
||
| if err := exec.Complete(outputKey, outputDataMap); err != nil { |
Contributor
There was a problem hiding this comment.
Not for this PR, but we should also save the failed messages.
Member
Author
There was a problem hiding this comment.
can you elaborate, i don't understand
Contributor
There was a problem hiding this comment.
An invalid json response we should also be kept inside db. Someone may want to see the task response (even if it's invalid). I'm even thinking about passing this response, not just an error. But it just a thought and needs lot way thinking if this approach is valid.
Member
Author
|
@mesg-foundation/core ready for reviews |
ilgooz
previously approved these changes
Dec 19, 2018
krhubert
reviewed
Dec 19, 2018
Member
Author
|
@mesg-foundation/core ready for reviews. |
krhubert
previously approved these changes
Dec 20, 2018
Member
Author
|
I will fix the conflict after approval |
ilgooz
previously approved these changes
Dec 21, 2018
antho1404
previously approved these changes
Dec 21, 2018
Co-Authored-By: NicolasMahe <nicolas@mahe.me>
antho1404
force-pushed
the
feature/execution-result-error
branch
from
40164d6 to
54714c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #610. close #573.
simplified version of #596 (close #596)
I change the big modif on the proto def from #596 to just add
string error.