Skip to content

Remove vendor#693

Merged
krhubert merged 8 commits intodevfrom
feature/rm-vendor
Jan 13, 2019
Merged

Remove vendor#693
krhubert merged 8 commits intodevfrom
feature/rm-vendor

Conversation

@krhubert
Copy link
Copy Markdown
Contributor

@krhubert krhubert commented Jan 12, 2019

No description provided.

@antho1404
Copy link
Copy Markdown
Member

antho1404 commented Jan 13, 2019

It looks like we need to force the modules with go

go get: warning: modules disabled by GO111MODULE=auto in GOPATH/src;
	ignoring go.mod;
	see 'go help modules'

@krhubert
Copy link
Copy Markdown
Contributor Author

krhubert commented Jan 13, 2019

Or move sources outside $GOPATH which is more preferable one by go

NicolasMahe
NicolasMahe requested changes Jan 13, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test are failing.
Solve with #697

NicolasMahe
NicolasMahe previously approved these changes Jan 13, 2019
View reviewed changes
@krhubert krhubert merged commit 5cd80b0 into dev Jan 13, 2019
@ilgooz ilgooz deleted the feature/rm-vendor branch January 13, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NicolasMahe NicolasMahe NicolasMahe approved these changes

+1 more reviewer

@ilgooz ilgooz ilgooz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@krhubert @antho1404 @NicolasMahe @ilgooz