Fix missing update to golang v1.11.4#699
Merged
NicolasMahe merged 13 commits intodevfrom Jan 15, 2019
Merged
Conversation
NicolasMahe
changed the title
NicolasMahe
force-pushed
the
fix/update-to-golang-v1.11.4
branch
from
d15e598 to
808e09b
Compare
NicolasMahe
changed the title
NicolasMahe
requested review from
antho1404,
ilgooz and
krhubert
and removed request for
antho1404 and
krhubert
ilgooz
previously approved these changes
Jan 14, 2019
NicolasMahe
commented
Jan 14, 2019
Member
Author
|
@ilgooz i find a problem and fix it. Please review again |
krhubert
reviewed
Jan 14, 2019
NicolasMahe
commented
Jan 14, 2019
| # generate mocks for docker.CommonAPIClient that used by container package. | ||
| mockery -name CommonAPIClient -dir ./vendor/github.com/docker/docker/client -output ./utils/docker/mocks | ||
| # TODO: to fix | ||
| # mockery -name CommonAPIClient -dir ./vendor/github.com/docker/docker/client -output ./utils/docker/mocks |
Member
Author
|
Except problem with mock for docker client (#701), PR ready to review ;) |
krhubert
approved these changes
Jan 14, 2019
Member
|
force merge is bad #719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.