Conversation
df09b75 to
f4ed582
Compare
f4ed582 to
02a0720
Compare
5f55193 to
4f34272
Compare
|
@mesg-foundation/core please review |
antho1404
left a comment
There was a problem hiding this comment.
I don't think this PR is needed. Few reasons for that:
- It adds a lot of complexity for the hashing method, we duplicate some logic from another library without having all the history from that (list of pending issues for example). If we really want to have this change I would recommend to fork and fix the library and even better to do a PR on that project.
- This hash is not critical anymore. We needed a deterministic hash even with different modifications in the structure itself for the services but we moved to the tar sum to generate the hash so this is not critical anymore.
- There is still the problem with the executions that if we have a hash that can change from one version to another it's a problem but for now executions are only local and temporary so it's not really a big problem and also we can always have our own specific hash method where we hash an array that we create for example.
I strongly feel that this development is too complex to solve an issue that will be solved by #731.
|
|
||
| // Sha1 takes a data structure and returns its md5 hash as string. | ||
| func Sha3(v interface{}) [64]byte { | ||
| return sha3.Sum512(serialize(v)) |
There was a problem hiding this comment.
Wrong command and why sha3 is 512 bits?
|
This PR is way less important since PR #731 has been merged. I suggest to keep the current hash package (https://github.com/cnf/structhash) @krhubert any suggestion why we should merge this PR? |
features:
omitemptyfiled and extend structsversionmethodandlastversionare not included because core doesn't' use it, but it could be easily extended