Skip to content

Add marketplace service#797

Closed
NicolasMahe wants to merge 47 commits intodevfrom
ss/marketplace-simplified
Closed

Add marketplace service#797
NicolasMahe wants to merge 47 commits intodevfrom
ss/marketplace-simplified

Conversation

@NicolasMahe
Copy link
Copy Markdown
Member

@NicolasMahe NicolasMahe commented Mar 7, 2019

No description provided.

…st of address is authorized, and then return the service deployment source and type.
@antho1404
Copy link
Copy Markdown
Member

  • The publishServiceVersion works fine, just some feedback on the API Simplify createServiceVersion api marketplace#15
  • sendSignedTransaction works great
  • The listServices task doesn't return anything
  • I got an error with the getService (maybe timeout: 10000 is too low, why even a specific timeout)
service |  error while downloading manifest  ipfs :: QmcVUzKw1YHwpHi7V3hEcigq4PXhw26wuEK2TDL6pC7NBP RequestError: Error: ESOCKETTIMEDOUT

Didn't test the other tasks but I think some are not necessary:

  • disableServiceOffer
  • transferServiceOwnership

Also some could be done directly on marketplace.mesg.com:

  • createServiceOffer
  • purchase
    This doesn't needs to be on the system service and can be done directly on the website with metamask and nice UI

@NicolasMahe
Copy link
Copy Markdown
Member Author

NicolasMahe commented Mar 12, 2019

Tasks disableServiceOffer and transferServiceOwnership removed

@NicolasMahe
Copy link
Copy Markdown
Member Author

Task listServices fixed

@NicolasMahe NicolasMahe changed the title Add marketplace core service Add marketplace service Mar 12, 2019
@NicolasMahe
Copy link
Copy Markdown
Member Author

closing in favor of #810

@NicolasMahe NicolasMahe deleted the ss/marketplace-simplified branch March 19, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants