Deterministic hash - refactor and fix deployment#804
Merged
krhubert merged 2 commits intofeature/determistic-hashfrom Mar 11, 2019
Merged
Deterministic hash - refactor and fix deployment#804krhubert merged 2 commits intofeature/determistic-hashfrom
krhubert merged 2 commits intofeature/determistic-hashfrom
Conversation
7452d66 to
59fd1d5
Compare
Merged
Member
|
@antho1404 could you explain a more clearly what the function
I really think we should avoid to untar by "hand". I feel there are many things that is missing in this simple implementation of untar and will fire back on more complicated archive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #731
After a long time trying to go deep on why the hash was different between git and the tarball from github and our tarball I found out 2 things:
The docker untar function we used was the cause so I wrote a function to untar directly the content without the extra work that docker needs (here we don't care about docker).
I also did some refactoring on the
FromArchive/FromURLfunction to have the url that uses the untar system and the tarball received is also untared to make sure the process is the same whatever the source of deployment and with all that now everything works fineHere are some manual tests
Feel free to test it yourself and verify that you get the same hashes