api: make New to receive Container as a required param#872
Merged
Conversation
Contributor
ilgooz
commented
Apr 11, 2019
ilgooz
commented
- drop support for receving Options as params since there is no need anymore.
* drop support for receving Options as params since there is no need anymore.
ilgooz
force-pushed
the
feature/api-require-container
branch
from
92b5f3a to
d0f45ef
Compare
krhubert
previously approved these changes
Apr 11, 2019
antho1404
approved these changes
Apr 11, 2019
antho1404
approved these changes
Apr 11, 2019
krhubert
approved these changes
Apr 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.