Merged
Conversation
ilgooz
force-pushed
the
refactoring/service/simplify-stop
branch
5 times, most recently
from
2fb5770 to
215bd2d
Compare
ilgooz
force-pushed
the
refactoring/service/simplify-stop
branch
from
215bd2d to
9e8eb64
Compare
* moved Dependency.Stop() logic into Service.Stop(). * return Stop() errors for all dependencies, not just the first one. * removed unneeded TestStopDependency() & TestIntegrationStopDependency() tests.
ilgooz
force-pushed
the
refactoring/service/simplify-stop
branch
from
9e8eb64 to
c254b15
Compare
krhubert
approved these changes
Apr 16, 2019
antho1404
reviewed
Apr 17, 2019
Member
antho1404
left a comment
antho1404
left a comment
There was a problem hiding this comment.
why did you remove the mutex here ? I'm not really sure why we had one in the first place maybe to fix some strange behaviors with docker when we stop containers or something like that
Contributor
Author
That mutex was there to prevent concurrent writes to |
antho1404
approved these changes
Apr 17, 2019
NicolasMahe
approved these changes
Apr 17, 2019
NicolasMahe
reviewed
Apr 17, 2019
ilgooz
added a commit
that referenced
this pull request
Apr 17, 2019
this bug was introduced by #884. service itself should always be stopped first to give it a chance to properly shutdown itself. if depencies were stopped first, service may try to reconnect them or may start some fault toleration protocols for no reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.