Marketplace: load service on demand#897
Merged
NicolasMahe merged 4 commits intodevfrom Apr 23, 2019
Merged
Conversation
NicolasMahe
force-pushed
the
ss/marketplace-service-ondemand-loading
branch
5 times, most recently
from
0c4b618 to
d96c243
Compare
NicolasMahe
force-pushed
the
ss/marketplace-service-ondemand-loading
branch
from
d96c243 to
8b7a8e5
Compare
Member
Author
|
@mesg-foundation/core ready for review |
antho1404
requested changes
Apr 23, 2019
Member
antho1404
left a comment
antho1404
left a comment
There was a problem hiding this comment.
Compilation issue while building the docker image
src/tasks/prepareCreateServiceOffer.ts(24,35): error TS2339: Property 'versions' does not exist on type 'Service'.
src/tasks/preparePurchase.ts(25,111): error TS2339: Property 'offers' does not exist on type 'Service'.
src/tasks/preparePurchase.ts(26,27): error TS2339: Property 'offers' does not exist on type 'Service'.
…ful data manually
Member
Author
It's fixed now. please review |
NicolasMahe
commented
Apr 23, 2019
|
|
||
| // get offer data | ||
| const offerIndex = new BigNumber(inputs.offerIndex) | ||
| assert.ok(offerIndex.isInteger() && offerIndex.isGreaterThanOrEqualTo(0) && offerIndex.isLessThan(service.offers.length), 'offer index is out of range') |
Member
Author
There was a problem hiding this comment.
A similar test is done in getServiceOffer.
antho1404
approved these changes
Apr 23, 2019
Member
antho1404
left a comment
antho1404
left a comment
There was a problem hiding this comment.
Ok for me, I got a lot of errors when getting the manifest, either with a timeout or not a valid manifest but I guess because we changed the node and the data structure. We really need a fresh marketplace to test correctly :)
ilgooz
approved these changes
Apr 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependant on #896
This pr change the way service's versions, offers and purchases are fetched.
Before, getting a service also fetch everything.
Now, the child-data needs to be explicitly fetched.
Task
getServicestill returns the same payload, but tasklistServiceonly returns the "basic" service data: sid, owner and createTime.TODO: