Skip to content

Update ergoCub1 wrist range of motion#400

Merged
pattacini merged 2 commits intomesh-iit:masterfrom
fiorisi:master
Mar 20, 2025
Merged

Update ergoCub1 wrist range of motion#400
pattacini merged 2 commits intomesh-iit:masterfrom
fiorisi:master

Conversation

@fiorisi
Copy link
Contributor

@fiorisi fiorisi commented Mar 20, 2025

The PR updates:

  • The range of motion of the wrist roll and wrist pitch.
  • The range of motion of the index ab/adduction.

Associated documentation:

Update wrist RoM.
@fiorisi fiorisi added the bug Something isn't working label Mar 20, 2025
@fiorisi fiorisi self-assigned this Mar 20, 2025
@fiorisi fiorisi requested a review from pattacini as a code owner March 20, 2025 14:57
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fiorisi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request updates the range of motion for the wrist roll and wrist pitch joints of the ergoCub1 robot, as documented in the ergoCub1-joints.md file. The hardware and software limits for both joints have been adjusted. The changes are based on issue #202 in the ergocub-design-lowerarm repository and the robots-configuration repository.

Highlights

  • Wrist Roll Range Update: The hardware and software range of motion for the wrist roll joint has been updated from -62/+52 degrees and -60/+50 degrees to -20/+30 degrees, respectively.
  • Wrist Pitch Range Update: The hardware and software range of motion for the wrist pitch joint has been updated from -32/+32 degrees and -30/+30 degrees to -20/+20 degrees, respectively.

Changelog

  • docs/ergoCub1/ergoCub1-joints.md
    • Updated the hardware and software range of motion for the wrist roll joint from -62/+52 and -60/+50 degrees to -20/+30 degrees.
    • Updated the hardware and software range of motion for the wrist pitch joint from -32/+32 and -30/+30 degrees to -20/+20 degrees.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Trivia time!

What is the purpose of a spherical parallel mechanism, as mentioned in the documentation?

Click here for the answer
Spherical parallel mechanisms are used to achieve three rotational degrees of freedom about a fixed point, often used in robotic wrists to provide dexterity.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the range of motion for the wrist roll and wrist pitch joints in the ergoCub1 robot's documentation. The changes appear to be straightforward updates to numerical values in a table.

Merge Readiness

The pull request appears to be a simple documentation update, and the provided links to associated documentation seem to support the changes. I am unable to directly approve the pull request, and users should have others review and approve this code before merging. Given the limited scope and the supporting documentation, the pull request seems ready for merging.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pattacini pattacini merged commit 689e713 into mesh-iit:master Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants