Skip to content

Conversation

@JohannesRudolph
Copy link
Member

No description provided.

@github-actions
Copy link

Error in deno fmt. Please check the Action logs.

@JohannesRudolph JohannesRudolph force-pushed the feature/deno-cliffy-upgrade branch from 3ec2904 to d70c314 Compare September 29, 2022 16:30
@JohannesRudolph JohannesRudolph added the automerge instruct kodiak to put this PR into merge queue label Sep 29, 2022
@ghost ghost removed the automerge instruct kodiak to put this PR into merge queue label Sep 29, 2022
@ghost
Copy link

ghost commented Sep 29, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

deno 1.26 contains a breaking change (Deno.setRaw) that we need to use
a newer version of cliffy to stay compatible.

cliffy in turn had breaking changes around its command API which
required some significant refactoring to support cliffy now type-checking
commands much more strictly
changing this in response to a warning generated by deno 1.26, comply with this
this is useful to analyze dependencies and binary size
js bundlesize affects deno startup performance
@JohannesRudolph JohannesRudolph force-pushed the feature/deno-cliffy-upgrade branch from d70c314 to c91d942 Compare September 29, 2022 19:34
@JohannesRudolph JohannesRudolph added the automerge instruct kodiak to put this PR into merge queue label Oct 4, 2022
@ghost ghost merged commit d5b4129 into main Oct 4, 2022
@ghost ghost deleted the feature/deno-cliffy-upgrade branch October 4, 2022 09:41
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge instruct kodiak to put this PR into merge queue feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant