feat: harmonize error message when cli not authenticated #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JohannesRudolph
commented
Jul 20, 2021
JohannesRudolph
commented
- first suggest how to fix with the native cli command
- then suggest how to disconnect collie
- first suggest how to fix with the native cli command - then suggest how to disconnect collie
Jelledb
approved these changes
Jul 21, 2021
Jelledb
added a commit
that referenced
this pull request
Jul 21, 2021
* fix: Collie config no longer crashes (#50) * fix: links for badges (#59) * fix: `collie cache` will show help (#58) * feat: Add tutorial links directly in README. (#52) * feat: Add images Wiki (#63) * feat: Rename totalUsageCost, fix issue with cached tenants, fix costs table missing data (#64) * Renamed `totalUsageCost` to `cost` so it takes less space * Fixed an issue with retrieving cached tenants. * Fixed table only showing one month per tenant at maximum (closes #51) * Update README.md Links were pointing to the wrong Wiki sections * fix: Log statements not hidden when piping collie output (#62) Now properly disables log output breaking the output when collie stdout is piped into a file or different command. * Add Website to README (#69) * feat: Avoid cli setup checks when not required (#68) * feat: Avoid cli setup checks when not required In order to optimize startup time, especially when only issuing a non cloud-cli required command, collie now only checks cloud cli configuration when required. * fix: setup logger before running commands and await it not awaiting the logger configuration can cause loosing logs * feat: run cli checks concurrently see discussion in #68 * feat: add debug logs to ShellRunner for every command * style: deno fmt Co-authored-by: Johannes Rudolph <jrudolph@meshcloud.io> * feat: Improved JSON parsing so it always logs a message, including the command. (#57) * feat: harmonize error message when cli not authenticated (#70) * Feature/issue 56 (#71) * feat: detect installed cli versions match expectations if not, give installation hints via collie readme. fixes #56 * feat: Update version number (#73) Co-authored-by: Dennis Murtic <73823855+dmurtic@users.noreply.github.com> Co-authored-by: Thomas Felix <1186998+tfelix@users.noreply.github.com> Co-authored-by: Johannes Rudolph <jrudolph@meshcloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.