[Bug] RX Boosted Gain Mode switches to OFF when upgrading to v1.14.1

[jeroenvermeulen]

Already discussed in the thread of the PR: first finding + more testing

The problem only occurs in repeater and room-server, not in the companion firmware.

Fresh install of v1.14.1:
RX Boosted Gain Mode = ON

Upgrade from v1.14.0 to v1.14.1:
RX Boosted Gain Mode = OFF => unexpected / inconsistent

Steps to repeat the problem:

• Flash previous repeater firmware v1.14.0 using the web flasher, with 'Erase device' checked
• Connected to serial CLI
• set radio 869.6179809,62.5,8,8
• reboot
• Flash repeater firmware v1.14.1 using the web flasher, with Erase device NOT checked
• get radio.rxgain returns off => UNEXPECTED

In previous releases where the radio.rxgain setting was not availble, the setting was always ON.
So when you upgrade to 1.14.1 and don't think about out, it suddenly switches to OFF.

Fix if you want to keep the old behaviour:

After upgrading to v1.14.1 execute in CLI: set radio.rxgain on

[cra0]

Can confirm I've experienced the same thing on the xiao nRF52840

[liamcottle]

This is unfortunate...

Not ideal that all repeaters that are upgraded are having this get disabled.
Most repeaters get updated via OTA, so an erase before upgrade isn't the solution.

Will need to be fixed before next release, else would prob have to revert that PR.

[s56oa]

Same problem on RAK 4631 after upgrade of repeater from 1.14 to 1.14.1

[jeroenvermeulen]

I have built the dev branch and tested the upgrade from 1.14.0 to 8009cf0 on Heltec HTIT Tracker.
I can confirm the problem is SOLVED in the dev branch.

I will close the issue since the fix is in the dev branch and will be in the next release.

@weebl2000 has fixed it in such a way that all repeaters will have RX Boosted Gain Mode set to 'ON' in after applying the next release, no matter if they come from 1.14.1 or an earlier release. From the next release (1.14.2?) onwards repeater owners can set the radio.rxgain how they want and the setting will be kept during upgrades.

[LitBomb]

For Station G2, the default in its platformio.ini, -D SX126X_RX_BOOSTED_GAIN=1 is commented out.

RX boosted gain should NOT be enabled after upgrade if it was disabled previously. It sounds like this fix will flip RX boosted gain on no matter what, which would be wrong for Station G2 repeaters.

[Station_G2]
.
.
.
;  -D SX126X_RX_BOOSTED_GAIN=1 - DO NOT ENABLE THIS!
;  https://wiki.uniteng.com/en/meshtastic/station-g2#impact-of-lora-node-dense-areashigh-noise-environments-on-rf-performance

[jeroenvermeulen]

@LitBomb I dove back into the code and if I understand correctly, the value of SX126X_RX_BOOSTED_GAIN will be used as default if set. Looks like the Station G2 is the only one not having -D SX126X_RX_BOOSTED_GAIN=1
https://github.com/meshcore-dev/MeshCore/blob/dev/examples/simple_repeater/MyMesh.cpp#L892-L898
I don't own a Station G2, otherwise I would just build dev to confirm.
So I recommend to just doublecheck after the upgrade to next version but it should be OK.

[theinfguy]

Have built dev nightly repeater FW and erased & flashed to my Heltec v4.2.

It is still deaf compared to v3 companion.

[jeroenvermeulen]

@LitBomb @weebl2000 Update regarding the Station G2:
I still don't own a Station G2 but tested on a Heltec HTIT Tracker V1 by commenting out -D SX126X_RX_BOOSTED_GAIN=1 in its platformio.ini.
I have to say @LitBomb's concern was justified:
radio.rxgain is ON when you build the current dev branch (tested 467959c) with that configuration.
As far as I can see the Station G2 is the only device with this exception, so I have created PR #2134 to fix this.

[jeroenvermeulen]

@theinfguy Have you tried playing with set radio.rxgain off and set radio.rxgain on in CLI?
If OFF works better for you, you will have to re-apply the change once after next upgrade, probably 1.14.2.
From that point on the setting should be saved.