Skip to content

Conversation

@IoTThinks
Copy link

I have cleaned up and creating a new PR to to display default temperature to all ESP32 and NRF52 boards.

  • Added default temperature from ESP32 MCU and NRF52 MCU
  • Added NRF52Board.h and NRF52Board.cpp
  • Modified NRF52 variants to extend from NRF52Board to share common feature

Old PR is here: #1163.
Thanks a lot.

Added NRF52Board.h and NRF52Board.cpp
Modified NRF52 variants to extend from NRF52Board to share common feature
@liamcottle
Copy link
Member

Looks good thanks!

My last comment is on the behaviour of boards that have an external temperature sensor installed as well.

We would now be using TELEM_CHANNEL_SELF for both the internal mcu temperature sensor, and any external temperature sensors.

https://github.com/meshcore-dev/MeshCore/blob/2deb9cf1440a658c0b51cb824c6582eed7fb87f1/examples/simple_repeater/MyMesh.cpp#L179C32-L179C50

telemetry.addTemperature(TELEM_CHANNEL_SELF, BME280.readTemperature());

Wondering if this will cause any issues, and if so, which one takes priority unless we move external sensors to a separate channel.

@IoTThinks
Copy link
Author

I suggest to move the telemetry of external sensors to Channel 2.

That would be clean and clear.

What do you think?

@IoTThinks
Copy link
Author

From some friends, the later Temperature will override and take priority.

@IoTThinks IoTThinks requested a review from liamcottle December 13, 2025 10:59
@IoTThinks
Copy link
Author

IoTThinks commented Dec 14, 2025

@liamcottle I managed to add a BME680 to a Heltec repeater.

This is from built-in sensor.
image

This is when we add BME680.
Yes, because we add the temperature of MCU before BME680.
The temperature of BME680 will override the temperature of MCU.
image

So the PR is quite safe.

@liamcottle
Copy link
Member

Great thanks, I'm happy with the default MCU temp sensor being overriden by the external sensors for now.

We can look to move external sensors to a separate channel in a future PR if that is preferred.

I like the idea of external sensors on a separate channel than "self", but to keep this PR minimal without a breaking change for existing users, let keep it as is.

Looks good to me :)

@ripplebiz ripplebiz merged commit d67f311 into meshcore-dev:dev Dec 15, 2025
@fizzyfuzzle
Copy link

fizzyfuzzle commented Dec 18, 2025

@IoTThinks I just flashed the nightly (18-Dec-2025 02:08) to a WisMesh Tag and a t114, but I can not see the temperature in the telemetrics on the mobile app? Is there something additional I need to do to enable this feature? Thanks

Edit:
Ah I see this is only available in the Repeater Telemetrics, is there a reason for this? Would also be nice to have it in the companions I guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants