-
Notifications
You must be signed in to change notification settings - Fork 333
Added default temperature from ESP32 MCU and NRF52 MCU #1206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default temperature from ESP32 MCU and NRF52 MCU #1206
Conversation
Added NRF52Board.h and NRF52Board.cpp Modified NRF52 variants to extend from NRF52Board to share common feature
|
Looks good thanks! My last comment is on the behaviour of boards that have an external temperature sensor installed as well. We would now be using
Wondering if this will cause any issues, and if so, which one takes priority unless we move external sensors to a separate channel. |
|
I suggest to move the telemetry of external sensors to Channel 2. That would be clean and clear. What do you think? |
|
From some friends, the later Temperature will override and take priority. |
|
@liamcottle I managed to add a BME680 to a Heltec repeater. This is when we add BME680. So the PR is quite safe. |
|
Great thanks, I'm happy with the default MCU temp sensor being overriden by the external sensors for now. We can look to move external sensors to a separate channel in a future PR if that is preferred. I like the idea of external sensors on a separate channel than "self", but to keep this PR minimal without a breaking change for existing users, let keep it as is. Looks good to me :) |
|
@IoTThinks I just flashed the nightly (18-Dec-2025 02:08) to a WisMesh Tag and a t114, but I can not see the temperature in the telemetrics on the mobile app? Is there something additional I need to do to enable this feature? Thanks Edit: |


I have cleaned up and creating a new PR to to display default temperature to all ESP32 and NRF52 boards.
Old PR is here: #1163.
Thanks a lot.