Pass rtc_clock to MicroNMEALocationProvider in all variants #1364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weebl2000
force-pushed
the
pass-rtc_clock-to-locationprovider
branch
from
73ea141 to
82381ef
Compare
weebl2000
force-pushed
the
pass-rtc_clock-to-locationprovider
branch
from
82381ef to
86179e9
Compare
Enable GPS time synchronization across all variants by passing &rtc_clock to MicroNMEALocationProvider. When GPS gets a valid fix, the RTC clock is now updated automatically every 30 minutes. Updated 16 variants: rak4631, lilygo_tbeam_SX1262, rak_wismesh_tag, lilygo_tbeam_supreme_SX1262, thinknode_m3, heltec_v4, thinknode_m1, lilygo_tbeam_SX1276, meshadventurer, nano_g2_ultra, heltec_v3, promicro, xiao_c3, heltec_tracker_v2, keepteen_lt1, heltec_mesh_solar.
weebl2000
force-pushed
the
pass-rtc_clock-to-locationprovider
branch
from
86179e9 to
87886fc
Compare
weebl2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Several variants were constructing
MicroNMEALocationProviderwithout passing thertc_clockreference, even though one was available in scope. This means GPS timefixes were never synced to the RTC on those boards.
This PR adds
&rtc_clockas the second constructor argument across all 18 affectedvariants, ensuring GPS-derived time is propagated to the RTC consistently.
Changed variants
heltec_mesh_solar, heltec_tracker_v2, heltec_v3, heltec_v4, keepteen_lt1,
lilygo_tbeam_1w, lilygo_tbeam_SX1262, lilygo_tbeam_SX1276,
lilygo_tbeam_supreme_SX1262, meshadventurer, nano_g2_ultra, promicro, rak3112,
rak3401, rak4631, rak_wismesh_tag, thinknode_m3, xiao_c3
Notes
heltec_trackeris intentionally excluded — it will be addressed by Support GPS properly on Heltec Wireless Tracker v1.x #1351(heltec_wireless_tracker_gps) which supersedes the change for that variant.
, &rtc_clockto the existingMicroNMEALocationProvider(Serial1)call. No behavioral changes beyondenabling RTC sync from GPS.