Fix Unbounded sprintf with sender_name in BaseChatMesh.cpp#1975
Closed
hylaride wants to merge 1 commit into
Closed
Fix Unbounded sprintf with sender_name in BaseChatMesh.cpp#1975hylaride wants to merge 1 commit into
hylaride wants to merge 1 commit into
Conversation
robekl
added a commit
to robekl/MeshCore
that referenced
this pull request
Mar 23, 2026
Reimplements meshcore-dev/MeshCore PR meshcore-dev#1975 on top of 467959c for the 1.14.1 maintenance branch. References: PR: meshcore-dev#1975 snprintf reference: https://en.cppreference.com/w/c/io/fprintf Rationale: The original code used sprintf to prepend the sender name to outgoing text messages without an explicit bound, which is unnecessary risk in a message-construction path. This backport switches to bounded snprintf, handles a null sender name defensively, and keeps the existing truncation logic intact. The patch is confined to one formatting site in BaseChatMesh and is appropriate for a maintenance branch as a focused safety fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sprintf((char *)&temp[5], "%s: ", sender_name)has no length limit. Ifsender_nameis longer than the space left intemp(aboutMAX_TEXT_LEN + 32bytes fromtemp[5]onward), the write goes past the end oftemp.A remote host (e.g. over BLE or other future code) could send a long string as
sender_nameand trigger the overflow when the device sends a group message.This fix updates src/helpers/BaseChatMesh.cpp (sendGroupMessage):
Currently, the companion radio example in
examples/companion_radio/MyMesh.cppalready bounds name:so most users shouldn't currently experience this, but who knows what future people may do with their own clients.