Conversation
|
Looking through the history, this one also appears justified. The incorrect GPS control mapping was introduced in What makes this a strong fix is that the same commit appears to have simply misread the Heltec board docs: the official tracker pinout labels Authoritative source: |
Reimplements meshcore-dev/MeshCore PR meshcore-dev#2058 on top of 467959c for the 1.14.1 maintenance branch. References: PR: meshcore-dev#2058 Heltec ESP32 documentation index: https://docs.heltec.org/en/node/esp32/index.html Rationale: This patch updates the Heltec Tracker GNSS mapping so GPIO 35 is treated as reset and GPIO 36 as PPS, which matches the later fix and the board documentation comments. The change is confined to the Tracker variant configuration and its target comment. It is a classic board-definition correction and does not affect shared GPS parsing or transport behavior.
1 participant
Summary
Why this is the right fix
Heltec's Wireless Tracker documentation identifies GPIO35 as GNSS_RST and GPIO36 as PPS. The current variant defined GPIO35 as PIN_GPS_EN and GPIO36 as PIN_GPS_RESET, which inverted the documented control lines and omitted the PPS signal entirely.
This change moves PIN_GPS_RESET to 35, adds PIN_GPS_PPS on 36, and removes the undocumented dedicated GPS enable pin from the variant. That keeps the board definition aligned with the vendor pin map and matches how this target already shares peripheral power through PIN_VEXT_EN.
Authoritative source:
Validation
Testing Firmware
This change has been built into the testing firmware at meshcore.eklhq.com. Help with testing would be appreciated.