Skip to content

fix(sensecap_solar): correct TX LED after remap & power-button pin changes#2157

Merged
oltaco merged 2 commits intomeshcore-dev:devfrom
aXistem-dev:fix/sensecap-solar-tx-led-12
Apr 25, 2026
Merged

fix(sensecap_solar): correct TX LED after remap & power-button pin changes#2157
oltaco merged 2 commits intomeshcore-dev:devfrom
aXistem-dev:fix/sensecap-solar-tx-led-12

Conversation

@Confituurke
Copy link
Copy Markdown
Contributor

Updates the SenseCap Solar build flag P_LORA_TX_LED from 11 to 12 so LoRa TX activity is driven on the blue LED again, consistent with variants/sensecap_solar/variant.h (LED_BLUE / PIN_LED on pin 12).

SenseCap Solar LED GPIO definitions were corrected in #1689 . A later power-button–related pin mapping change e323755 , #1873 updated board wiring, but P_LORA_TX_LED changed to 11, which maps to LED_WHITE in the current headers and caused drift between the forks. That made the white LED blink on TX, which looks like a white/blue swap even though the underlying problem was the TX LED build flag not matching the updated LED pin macros.

@ripplebiz & @liamcottle FYI and approval; so these don't get changed/overwritten in another future PR.

@Specter242 FYI; since you initiated PR #1873

Thank you

@Specter242
Copy link
Copy Markdown
Contributor

Thanks, this seems like it works better.

Align TX activity LED with LED_BLUE / variant.h after LED definition
and power-button pin mapping changes.
@Confituurke Confituurke force-pushed the fix/sensecap-solar-tx-led-12 branch from d97a4bf to 3fcf5b5 Compare April 19, 2026 09:20
@Confituurke
Copy link
Copy Markdown
Contributor Author

Rebased to version 1.15.0 dev-branch

@oltaco
Copy link
Copy Markdown
Member

oltaco commented Apr 24, 2026

Something doesn't seem quite right with this, can youchange the white LED setup in SenseCapSolarBoard::begin() so that it's not permanently lit?
image

--- a/variants/sensecap_solar/SenseCapSolarBoard.cpp
+++ b/variants/sensecap_solar/SenseCapSolarBoard.cpp
@@ -49,7 +49,7 @@ void SenseCapSolarBoard::begin() {

 #ifdef LED_WHITE
   pinMode(LED_WHITE, OUTPUT);
-  digitalWrite(LED_WHITE, HIGH);
+  digitalWrite(LED_WHITE, LOW);
 #endif
 #ifdef LED_BLUE
   pinMode(LED_BLUE, OUTPUT);

@oltaco
Copy link
Copy Markdown
Member

oltaco commented Apr 25, 2026

Thanks for your work on this everybody 👍

@oltaco oltaco merged commit 40d7fcf into meshcore-dev:dev Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants