Skip to content

add multibyte FAQ, reference awesome-meshcore community projects, minor changes#2172

Merged
liamcottle merged 3 commits intomeshcore-dev:mainfrom
LitBomb:patch-24
Apr 1, 2026
Merged

add multibyte FAQ, reference awesome-meshcore community projects, minor changes#2172
liamcottle merged 3 commits intomeshcore-dev:mainfrom
LitBomb:patch-24

Conversation

@LitBomb
Copy link
Copy Markdown
Contributor

@LitBomb LitBomb commented Mar 27, 2026

…or changes

- Add multi byte FAQ
- Reword amped radio output setting numbers
- Clarify repeater ID collision including distance, supercede meshcore-dev#1478
- Reference awesome meshcore for community projects. Supercede meshcore-dev#1893
@LitBomb
Copy link
Copy Markdown
Contributor Author

LitBomb commented Mar 27, 2026

this PR includes some other FAQ PRs that have not been merged yet. I added those changes in this PR and it supercedes the other ones, which can be closed without merging. They are

#1478
#1893

@dreirund
Copy link
Copy Markdown
Contributor

dreirund commented Mar 28, 2026

According to the diff, you introduce a bogous table of contents item

    - [⚠️ **WARNING: Set these values at your own risk. Incorrect power settings can permanently damage your radio hardware.**](#️-warning-set-these-values-at-your-own-risk-incorrect-power-settings-can-permanently-damage-your-radio-hardware)

(Anyway, naming this "frequently asked questions" seems a bit confusing, most of the things more seem like "further information and ressources", not questions that emipirically were asked often, or?)

@LitBomb
Copy link
Copy Markdown
Contributor Author

LitBomb commented Mar 28, 2026

I am not seeing the bogus table content item that you are referring. this is what I see in the diff:

image

And the table renders fine:
image

This is definitely a frequently asked question on multiple discord servers, and that is why I added it a couple months ago. More and more users are getting these 1W+ radios and they often ask what dbm to set to for these radios.

It is just further information rand resources to you if you don't have one of these 1W+ radios. It is a question every new 1W+ radio owner ask the first time they need to configure one for MeshCore.

@dreirund
Copy link
Copy Markdown
Contributor

I am not seeing the bogus table content item that you are referring. this is what I see in the diff:

When I open https://github.com/meshcore-dev/MeshCore/pull/2172/changes#diff-57cdcc6b6701a7ce3b3a8f8c0366e0e611e6fb1a1b8dd7cd29e3263b3e064c8bR84#:~:text=**WARNING:, i.e. the same as when in this pull request #2172 click on "Files Changed", then docs/faq.md, and then scroll down to the end of the first block of additions, I see:


image

This is definitely a frequently asked question on multiple discord servers, and that is why I added it a couple months ago. More and more users are getting these 1W+ radios and they often ask what dbm to set to for these radios.

I did not mean that specific item, but the general information that is in the docs/faq.md. Is really every piece of it a frequently asked question? Than I stand corrected and go away in shame on that point.

Regards!

Fixed an extra TOC jump link inserted by VSCode Markdown All in One VS Code extension.
@LitBomb
Copy link
Copy Markdown
Contributor Author

LitBomb commented Mar 29, 2026

with the line number this time, I see the markdown all in one VSCode extension inserted an extra jump link to the table of content. I have fixed that in this PR.

Thanks for the report!

@dreirund
Copy link
Copy Markdown
Contributor

with the line number this time, I see the markdown all in one VSCode extension inserted an extra jump link to the table of content.

If you generate the table of contents automatically (you actually did change the whole table of content, because you indented all entries one time -- why?), I think the whole document should have a rule that no stuff is within it that can confuse automatic generators.

I think here heading-formatting is misused to highlight some text. Thiis is wrong semantics. i think if ** (bold) is not enough, manual HTML formatting that affects text size only but semantically is not a heading should be used.

Regards!

@liamcottle
Copy link
Copy Markdown
Member

FYI, the new docs site automatically generates it's own table of contents.
https://docs.meshcore.io/faq/

@LitBomb
Copy link
Copy Markdown
Contributor Author

LitBomb commented Mar 30, 2026

@liamcottle can you approve and merge this PR? It is ready to go. Thanks!

@liamcottle
Copy link
Copy Markdown
Member

@liamcottle can you approve and merge this PR? It is ready to go. Thanks!

Have reviewed, looks good. There's a bunch of spelling mistakes and grammar issues though.
There also seems to be a bunch of double spaces instead of single spaces between new sentences on the same line.

I won't comment on each of those. Please revise and then I can merge :)

fixed typos and refined multibyte sections.
@LitBomb
Copy link
Copy Markdown
Contributor Author

LitBomb commented Mar 31, 2026

I found and fixed 2 typos. I reworded some sentences in the multibyte sections. I always use double spaces after a period between two sentences. :)

Thanks!

@dreirund
Copy link
Copy Markdown
Contributor

dreirund commented Apr 1, 2026 via email

@LitBomb
Copy link
Copy Markdown
Contributor Author

LitBomb commented Apr 1, 2026

I wrote 99% of this faq for over a year now since the start of the project. There are double spaces between every two sentences in this faq. Double spaces is the consistent way in this faq so far.

@liamcottle liamcottle merged commit 73fc967 into meshcore-dev:main Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants