fix: correct device model name for Heltec Wireless Paper#2407
Merged
liamcottle merged 1 commit intomeshcore-dev:devfrom Apr 26, 2026
Merged
fix: correct device model name for Heltec Wireless Paper#2407liamcottle merged 1 commit intomeshcore-dev:devfrom
liamcottle merged 1 commit intomeshcore-dev:devfrom
Conversation
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect device model name displayed in the MeshCore app for Heltec Wireless Paper.
Previously, the app showed "Heltec V3" because
target.handtarget.cppusedHeltecV3Boarddirectly, which returns"Heltec V3"fromgetManufacturerName().This PR introduces
HeltecWirelessPaperBoard, a minimal subclass ofHeltecV3Boardthat overridesgetManufacturerName()to return"Heltec Wireless Paper".Changes
variants/heltec_wireless_paper/target.h: AddedHeltecWirelessPaperBoardsubclass; updatedexterndeclarationvariants/heltec_wireless_paper/target.cpp: Updated board instance to useHeltecWirelessPaperBoardTesting
Tested on hardware (Heltec Wireless Paper) with both BLE and USB Companion firmware. Device model now correctly shows "Heltec Wireless Paper" in the MeshCore Android app settings.
This was discovered while testing the USB Companion firmware added in #2315.