Don't play startup tune if buzzer pref disabled#2460
Merged
liamcottle merged 1 commit intomeshcore-dev:devfrom May 1, 2026
Merged
Don't play startup tune if buzzer pref disabled#2460liamcottle merged 1 commit intomeshcore-dev:devfrom
liamcottle merged 1 commit intomeshcore-dev:devfrom
Conversation
recrof
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a user disables the buzzer by triple pressing the user button, the buzzer is silenced for all incoming messages, however when the user reboots the node, it still plays the startup tune.
This PR prevents the startup tune from playing if the user has disabled the buzzer in preferences.
Instead of calling
buzzer.startup()inbuzzer.begin(), it is deferred until after the quiet mode has been configured from the node preferences.Fixes: #2160
Supersedes: #1803
Tested on: