Add sanity check for DS3231 RTC probe#2498
Closed
oltaco wants to merge 1 commit intomeshcore-dev:devfrom
Closed
Conversation
Member
Author
|
Closed in favour of #2516 as there was a chance this sanity check could fail when the RTC was uninitialised due to power loss. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a sanity check after probing for DS3231 RTC on the I2C bus.
Some unrelated devices (such as the IMU20948) respond on the same I2C address as DS3231. This can cause AutodiscoverRTCClock to incorrectly identify a non-RTC device as a DS3231, resulting in a non-functioning clock.
The sanity check just makes sure that the data that is coming back is at least plausible.