Build fixes for some RP2040 targets#2684
Merged
Merged
Conversation
pins framework-arduinopico @ 1.50600.0+sha.6a1d13e9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a few RP2040 targets that were failing build and pins the platform so that we don't get caught out by upstream changes again and builds become reproducible.
The RP2040 framework-arduinopico made a change that causes an assert if you compile the BLE library without enabling bluetooth in the framework. Companion firmware has code in it which causes the platformio dependency checker to pull in BLE and then the build fails.
Adding
lib_ignore = BLEfor the USB targets fixes it.