return range with advert interval setting error #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates both local and flood advert preference setting errors to include the allowable range and time units
Contributor
Author
|
this does not change the time units, but if that is desired can also include that change. Just trying to decide what makes the most sense, probably both in minutes. |
Member
We won't be able to change the time units in the CLI command unless it's a new command. Since the app uses those CLI commands for the UI. Older clients would be sending invalid values to newer repeaters. |
agessaman
pushed a commit
to agessaman/MeshCore
that referenced
this pull request
Nov 8, 2025
return range with advert interval setting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates both local and flood advert preference
setting errors to include the allowable range and
time units
closes #142