Disable LED lights on t-echo device #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This change is very crude, with only one board affected.. we should not encourage changes that disable functionality without actual fixes. this should never be open as a PR. |
Contributor
Author
|
You are absolutely right, sorry for this PR. I tried to modify the behavior of flashing LED, but it's called deeper in the code and my programming knowledge is very fringe. I will try to find some more time to make it better. @recrof |
VirtualP1rate
added a commit
to VirtualP1rate/MeshCore
that referenced
this pull request
Oct 10, 2025
Disable LED lights on t-echo device
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the less-than-ideal change in the code, but is it possible to disable the LED lights on the T-Echo device for now, until someone adds an option in the UI to disable them?
They unnecessarily drain the battery, especially since the device cannot enter deep sleep by user control for now.
I hope there will be plenty of users who don’t like a device flashing like a Christmas tree.
Edit: sorry for Unverified commit, I used accidentally old one of my ssh keys ...