Skip to content

Conversation

@csrutil
Copy link
Contributor

@csrutil csrutil commented Sep 1, 2025

  • Add genericVibration class with 5-second cooldown and 1-second pulse
  • Integrate vibration triggers for new messages and contact discoveries
  • Add conditional compilation support with PIN_VIBRATION guard
  • Implement abstract interface for vibration in UITask system

@ripplebiz
Copy link
Collaborator

PR's should have 'dev' branch as base

@csrutil csrutil force-pushed the feature/vibration-feedback branch from e693570 to 5a0afbe Compare September 7, 2025 07:16
@csrutil csrutil changed the base branch from main to dev September 7, 2025 07:17
@csrutil
Copy link
Contributor Author

csrutil commented Sep 7, 2025

Well noted, I just changed the base branch to dev!

@ripplebiz
Copy link
Collaborator

Thanks. Is generally structured well, however, I'd suggest we rename the soundBuzzer() method to a more generic concept, maybe alertUser(UIEventType t) ...

And then the UITask impl can do potentially both, or one, of the current PIN_BUZZER conditional code, or this vibrate code.

@4np
Copy link

4np commented Sep 13, 2025

Perhaps accepting a collection of event types would be useful rather than a single type. Then you could send an alert to [.buzzer, .tactile, .speaker, .display].

Pseudo code in Swift:

enum UIEventType: Int {
  case buzzer
  case tactile
  case speaker
  case display

  static let all: [Self] = [.buzzer, .tactile, .speaker, .display]
}

- Add genericVibration class with 5-second cooldown and 1-second pulse
- Integrate vibration triggers for new messages and contact discoveries
- Add conditional compilation support with PIN_VIBRATION guard
- Implement abstract interface for vibration in UITask system
Consolidates soundBuzzer() and triggerVibration() into a unified notify() method
that handles both audio and haptic feedback based on UIEventType.
@csrutil csrutil force-pushed the feature/vibration-feedback branch from 5a0afbe to 043f37a Compare September 17, 2025 00:57
@ripplebiz ripplebiz merged commit b3e9fd7 into meshcore-dev:dev Sep 18, 2025
@ripplebiz
Copy link
Collaborator

Thanks for that. I have merged, but have also pushed a refactor/cleanup.

@csrutil
Copy link
Contributor Author

csrutil commented Sep 18, 2025

thanks @ripplebiz, it looks better after the cleanup. Hey @4np, it's a good idea, lets see if we need it in the future, thank you!

@orsib78
Copy link

orsib78 commented Oct 28, 2025

Hi! Just a quick question — I’m planning to build a BT Companion using a Heltec T114. I also have a speaker and a vibration motor for the build. Are these features already implemented? And if so, which pins on the board should I use to connect the speaker and/or the vibration motor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants