add heltec meshpocket board. #713
Conversation
variants/mesh_pocket/target.h
Outdated
| const char* getSettingName(int i) const override; | ||
| const char* getSettingValue(int i) const override; | ||
| bool setSettingValue(const char* name, const char* value) override; | ||
| }; |
There was a problem hiding this comment.
Are there plans to customise SensorManager? If not, you can just declare:
extern SensorManager sensors;
There was a problem hiding this comment.
The sensor section has been removed.
| display.print(str); | ||
| } | ||
|
|
||
| void GxEPDDisplay::fillRect(int x, int y, int w, int h) { |
There was a problem hiding this comment.
Just wondering why offset_x and offset_y are only applied in setCursor()?
There was a problem hiding this comment.
offset_x and offset_y only affect the text cursor position, making it easy to uniformly adjust the text area, while graphics drawing maintains the original coordinates for precise control.
|
It has been re-adapted according to commit #722. |
|
Still works good on TEcho, no regressions from the changes ... good work ! @Quency-D you might consider adding the following flags for meshpocket
|
Thank you very much for your suggestions, that's great. I've modified both. |
3 participants
I have tested that my proposed changes behave as described.
I have tested that my proposed changes do not cause any obvious regressions on the following devices: