Fix: Set device as connected after successful authentication #745
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViezeVingertjes
changed the title
Member
|
Looks good thanks! We will look to migrate to the connection state callbacks to mark it as disconnected as well. |
agessaman
pushed a commit
to agessaman/MeshCore
that referenced
this pull request
Nov 8, 2025
Fix: Set device as connected after successful authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deviceConnectedflag was previously set when the MTU was changed. This commit moves the flag to be set only after a successful authentication is complete so PIN does not disappear even before you had the chance to enter it.