Skip to content

Conversation

@jbrazio
Copy link
Contributor

@jbrazio jbrazio commented Sep 10, 2025

Fix a typo with variants/lilygo_tlora_v2_1 and take the opportunity to normalize all targets to lower case.

@jbrazio
Copy link
Contributor Author

jbrazio commented Sep 23, 2025

@ripplebiz can you review this ? Thanks.

@jbrazio
Copy link
Contributor Author

jbrazio commented Sep 27, 2025

@liamcottle @andymux @fdlamotte 15 days to review a basic PR.. do you guys need a hand ? I can help. 🥸

@liamcottle
Copy link
Member

Hey there,

Thanks for the tag. This might be a "basic PR", but it's also low priority...

We've had a lot of changes being merged in, and the last few releases have resulted in broken firmwares.

We don't really want to be rushed to merge in every change that presents itself.

Things like the web flasher also need to be discussed, as these changes would likely result in the .bin and .uf2 filenames changing case, which may or may not cause issues for the web flasher if it's expecting the old filename casing.

We appreciate the offer, but we will review changes as we can :)

@liamcottle liamcottle merged commit 2992062 into meshcore-dev:dev Sep 27, 2025
@recrof
Copy link
Collaborator

recrof commented Sep 27, 2025

@jbrazio I'm strongly recommending you to be patient.. this attitude does not make good blood in the team.

@jbrazio
Copy link
Contributor Author

jbrazio commented Sep 27, 2025

Please don’t overreact; that wasn’t my intention. The last part of my comment was meant to be a playful joke. However, the point I raised is still valid: "review" simply refers to providing feedback, and letting something sit for two weeks without any communication isn’t beneficial for anyone involved.

@liamcottle @recrof

@jbrazio jbrazio deleted the jbrazio/2025_44aa3add branch October 6, 2025 12:32
agessaman pushed a commit to agessaman/MeshCore that referenced this pull request Nov 8, 2025
…25_44aa3add

Normalize repeater target names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants