Skip to content

Comments

Update: MeshCore version in flake#19

Merged
fdlamotte merged 4 commits intomeshcore-dev:mainfrom
jorritvanderheide:main
Dec 5, 2025
Merged

Update: MeshCore version in flake#19
fdlamotte merged 4 commits intomeshcore-dev:mainfrom
jorritvanderheide:main

Conversation

@jorritvanderheide
Copy link

Updated the MeshCore version in the flake. I am not sure why, but on https://pypi.org/project/meshcore/ the latest release is 2.2.2, while on https://github.com/meshcore-dev/meshcore_py/releases it is 2.2.1.

I would suggest using GitHub as the source of truth, which is implemented in this commit. I also set the requirement in pyproject.toml back to 2.2.1.

@fdlamotte
Copy link
Collaborator

The versions correspond to the pypi releases, I rarely do releases on github ...

Latest is 2.2.2 but is not needed by meshcore-cli (the stats command has not been implemented there), I bumped requirements because I had issues and wanted to force pipx using all the latest versions ... in the end the problem is with latest bleak (2.0)

We can set the required version back to 2.2.1, but I don't think it's necessary. Putting the flake in sync is important though ;) so if it does problem with 2.2.1, you should probably bump the requirements to 2.2.2 (I didn't do it because I couldn't fin a way to get the hash for the lib without installing the package)

@jorritvanderheide
Copy link
Author

jorritvanderheide commented Dec 5, 2025

The nix run didn't work because of the version mismatch. Since you mostly release on pypi, I set restore that as the source. So the only change is the version number in the flake. Is it fine like this?

@fdlamotte fdlamotte merged commit 08dbbd4 into meshcore-dev:main Dec 5, 2025
@fdlamotte
Copy link
Collaborator

Thanks for upgrading the flake ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants