fix(*): rollback when target chain is not available#201
Merged
jzhe886 merged 1 commit intorelease-1.6from May 21, 2021
Merged
Conversation
Alexader
force-pushed
the
fix/rollback-index-1.6
branch
from
3e127fa to
d94d7fb
Compare
Codecov Report
@@ Coverage Diff @@
## release-1.6 #201 +/- ##
===============================================
- Coverage 73.08% 71.35% -1.74%
===============================================
Files 33 34 +1
Lines 2222 2388 +166
===============================================
+ Hits 1624 1704 +80
- Misses 404 479 +75
- Partials 194 205 +11
Continue to review full report at Codecov.
|
Alexader
force-pushed
the
fix/rollback-index-1.6
branch
3 times, most recently
from
0341aaf to
5c2228b
Compare
jzhe886
reviewed
May 20, 2021
internal/exchanger/receipt.go
Outdated
Comment on lines
+11
to
+14
| var pool *Pool | ||
| act, loaded := ex.receipts.Load(receipt.Ibtp.To) | ||
| if !loaded { | ||
| pool = NewPool() | ||
| ex.receipts.Store(receipt.Ibtp.To, pool) | ||
| } else { | ||
| pool = act.(*Pool) | ||
| } | ||
| pool.feed(receipt) | ||
|
|
Alexader
force-pushed
the
fix/rollback-index-1.6
branch
from
5c2228b to
9c13274
Compare
jzhe886
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.